Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to get mamba_train_example running. #312

Closed
wants to merge 1 commit into from

Conversation

joelburget
Copy link

Note that I also have to comment out "fast_ssm": True, on my machine.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not rewritten tests relating to key interfaces which would affect backward compatibility

You have tested formatting, typing and unit tests (acceptance tests not currently in use)

  • I have run make check-ci to check format and linting. (you can run make format to format code if needed.)

@joelburget
Copy link
Author

Fixes #311

@chanind
Copy link
Collaborator

chanind commented Oct 11, 2024

Looks like there's a test failure (should be a quick fix). This is also fixed in #226

Note that I also have to comment out `"fast_ssm": True,` on my machine.
@joelburget joelburget changed the base branch from main to huggingface-models October 11, 2024 15:53
@joelburget
Copy link
Author

Thanks @chanind -- I just rebased and changed the base to your branch.

@chanind chanind deleted the branch jbloomAus:huggingface-models November 10, 2024 18:51
@chanind chanind closed this Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants